[SYCL] Employ cached kernel #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Nov 19, 2019
s-kanaev
force-pushed
the
employ-cached-kernel
branch
from
747b12f to
43f600c
Compare
romanovvlad
requested changes
Nov 20, 2019
s-kanaev
force-pushed
the
employ-cached-kernel
branch
from
43f600c to
803ecb8
Compare
added 3 commits
November 20, 2019 11:16
* Don't cache kernels from customly built programs, i.e: - built with OpenCL C source - built with linking of multiple SYCL/OpenCL programs - built with custom build options Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
employ-cached-kernel
branch
2 times, most recently
from
7eaaccc to
9e2c902
Compare
romanovvlad
requested changes
Nov 20, 2019
Signed-off-by: Sergey Kanaev <[email protected]>
romanovvlad
previously approved these changes
Nov 20, 2019
bader
reviewed
Nov 20, 2019
bader
previously approved these changes
Nov 21, 2019
added 2 commits
November 21, 2019 11:27
Signed-off-by: Sergey Kanaev <[email protected]>
Kernel caching is only allowed for programs constructed with context only or context and device list. Moreover the program should be built with build_with_kernel_type method with default build options. Kernel caching is inadmissible for programs: * constructed with interoperability c-tor * constructed with linking c-tor * built with custom build options * built from source * built with distinct compile and link steps Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
employ-cached-kernel
branch
from
0c01d09 to
f4c9554
Compare
bader
pushed a commit
that referenced
this pull request
Nov 25, 2019
This patch fixes regression introduced by #847: programs and kernels are cached when program is built with sequence of compile_with_kernel_type()/compile_with_source() and then linked with link(). By design, caching of kernels and programs is permitted only when program is built with build_with_kernel_type() using the default options. Signed-off-by: Sergey Kanaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.