[SYCL] Fix regression with program building

[s-kanaev]

This patch fixes regression introduced by #847: programs and kernels are cached when program is built with sequence of compile_with_kernel_type()/compile_with_source() and then linked with link().

By design, caching of kernels and programs is permitted only when program is built with build_with_kernel_type() using the default options.

[s-kanaev]

Split to two pull requests

[bader]

This patch fixes regression

Could you elaborate on the problem this patch fixes, please?
"Improve tests. Improve implementation ..." is too vague. Please, be more specific.
Useful guide lines:

• https://llvm.org/docs/DeveloperPolicy.html#commit-messages
• https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

[bader]

What problem is introduced by #847?

[s-kanaev]

What problem is introduced by #847?

Programs and kernels tend to be cached in some illegal (for caching) use-cases.

[bader]

What problem is introduced by #847?

Programs and kernels tend to be cached in some illegal (for caching) use-cases.

What illegal cases are allowed with #847?

[s-kanaev]

What illegal cases are allowed with #847?

Programs and kernels are cached when program is built with sequence of compile_with_kernel_type/compile_with_source and then linked.

By design, caching of kernels and programs is permitted only when program is built with build_with_kernel_type with default options.

[bader]

What illegal cases are allowed with #847?

Programs and kernels are cached when program is built with sequence of compile_with_kernel_type/compile_with_source and then linked.

By design, caching of kernels and programs is permitted only when program is built with build_with_kernel_type with default options.

This is not clear from the patch, so I suggest adding this information to the commit message.

[s-kanaev]

This is not clear from the patch, so I suggest adding this information to the commit message.

Done

[s-kanaev]

Fixed sign-off

[bader]

This is not clear from the patch, so I suggest adding this information to the commit message.

Done

I can't find the fixed commit message. Could you share the link, please?
I'd like to use it for the squashed commit message.

[s-kanaev]

I can't find the fixed commit message. Could you share the link, please?
I'd like to use it for the squashed commit message.

Somehow, the empty commit just vanished away. I've edited description of the patch.