Skip to content

[SYCL] Remove intel_gpu_ehl target #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

steffenlarsen
Copy link
Contributor

This commit removes the Elkhart Lake (intel_gpu_ehl) target from the valid SYCL targets.

This commit removes the Elkhart Lake (intel_gpu_ehl) target from the
valid SYCL targets.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from jbrodman March 2, 2023 18:56
@steffenlarsen steffenlarsen requested review from a team as code owners March 2, 2023 18:56
Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for SYCL RT code-wise. I expect @dpcpp-specification-reviewers, @jbrodman to review the idea/reasoning.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen temporarily deployed to aws March 2, 2023 22:04 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 3, 2023 04:16 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 3, 2023 12:43 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 3, 2023 13:16 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 3, 2023 18:04 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 5, 2023 12:24 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 6, 2023 10:52 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 6, 2023 12:55 — with GitHub Actions Inactive
@jbrodman
Copy link
Contributor

jbrodman commented Mar 6, 2023

False negative on AMD?

@steffenlarsen
Copy link
Contributor Author

HIP Failed Tests (1):
SYCL :: Basic/gpu_max_wgs_error.cpp
Disabled in intel/llvm-test-suite#1635.

@steffenlarsen steffenlarsen merged commit 3a5b30f into intel:sycl Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants