-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL][FPGA] Implement num_simd_work_items kernel attribute #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5c0c51
to
2162b9b
Compare
AGindinson
reviewed
Nov 27, 2019
romanovvlad
reviewed
Nov 27, 2019
romanovvlad
reviewed
Nov 27, 2019
romanovvlad
reviewed
Nov 27, 2019
AGindinson
reviewed
Nov 27, 2019
romanovvlad
reviewed
Nov 27, 2019
AGindinson
reviewed
Nov 27, 2019
romanovvlad
reviewed
Nov 27, 2019
AGindinson
reviewed
Nov 27, 2019
01c6980
to
ff74b96
Compare
mlychkov
reviewed
Nov 28, 2019
daf8cac
to
850b0a7
Compare
#896 needs to be committed first |
7058216
to
ff45970
Compare
Rebased after merge. |
AGindinson
reviewed
Dec 3, 2019
818a2d6
to
6336491
Compare
AGindinson
previously approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple minor comments
05b6e2d
to
a1c49c0
Compare
AGindinson
previously approved these changes
Dec 4, 2019
a1c49c0
to
bdecdda
Compare
mlychkov
previously approved these changes
Dec 4, 2019
mlychkov
reviewed
Dec 4, 2019
Applies to a device function/lambda function. Indicates the number of X work items that should be processed in parallel. Valid values are positive integers. Signed-off-by: Dmitry Sidorov <[email protected]>
bdecdda
to
23f7a8d
Compare
mlychkov
approved these changes
Dec 4, 2019
erichkeane
reviewed
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to a device function/lambda function. Indicates the number
of X work items that should be processed in parallel. Valid values
are positive integers.
Signed-off-by: Dmitry Sidorov [email protected]