Skip to content

[SYCL][ESIMD] Address failures in ESIMD Emulator e2e tests #8726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 12, 2023
Merged

[SYCL][ESIMD] Address failures in ESIMD Emulator e2e tests #8726

merged 9 commits into from
Apr 12, 2023

Conversation

turinevgeny
Copy link
Contributor

@turinevgeny turinevgeny commented Mar 21, 2023 •
edited
Loading

  • Update CM Emulator to version 1.0.31, ubu22 package to align with CI testing;
  • Add libdw1 package as a new dependency of cm-cpu-emulation package.

@turinevgeny turinevgeny requested a review from a team as a code owner March 21, 2023 20:12
@turinevgeny turinevgeny temporarily deployed to aws March 21, 2023 23:43 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 22, 2023 03:38 — with GitHub Actions Inactive
bader
bader requested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turinevgeny, please, fix pre-commit failures.

@turinevgeny turinevgeny temporarily deployed to aws March 22, 2023 23:02 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 22, 2023 23:08 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 29, 2023 04:26 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 29, 2023 08:46 — with GitHub Actions Inactive
@dongkyunahn-intel
Copy link
Contributor

/verify

@turinevgeny turinevgeny temporarily deployed to aws April 4, 2023 21:23 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws April 4, 2023 21:24 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws April 10, 2023 22:57 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws April 11, 2023 00:34 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws April 11, 2023 16:43 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws April 11, 2023 18:37 — with GitHub Actions Inactive
@turinevgeny turinevgeny requested a review from a team as a code owner April 12, 2023 01:27
@turinevgeny turinevgeny temporarily deployed to aws April 12, 2023 01:55 — with GitHub Actions Inactive
bader
bader reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two changes in this patch, which I would prefer to commit separately. Missing dependency for Ubuntu 22 is not related to version update.
I'm okay to commit them together and fix remaining issues in follow-up patches as ESIMD validation is broken, but we need to update PR title and description.

devops/scripts/install_build_tools.sh
Comment on lines 16 to +19
libffi-dev \
libva-dev \
libtool \
libdw1 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these libraries added for cm-cpu-emulation? I think it's worth adding a comment to this script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know that. I can say that libffi-dev is used by cm-cpu-emulation, but that does not mean it is not used by something else.

@turinevgeny turinevgeny temporarily deployed to aws April 12, 2023 02:28 — with GitHub Actions Inactive
@turinevgeny turinevgeny changed the title [SYCL][ESIMD] Update CM Emulator to version 1.0.31. [SYCL][ESIMD] Address failures in ESIMD Emulator e2e tests Apr 12, 2023
@turinevgeny
Copy link
Contributor Author

There are two changes in this patch, which I would prefer to commit separately. Missing dependency for Ubuntu 22 is not related to version update. I'm okay to commit them together and fix remaining issues in follow-up patches as ESIMD validation is broken, but we need to update PR title and description.

Updated PR title and the description.

bader
bader approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make two follow-up changes:

  1. Update ESIMD test status on Windows to fix pre-commit.
  2. Add comments about packages required by cm-cpu-emulator.

@bader bader merged commit dd23a85 into intel:sycl Apr 12, 2023
@turinevgeny turinevgeny deleted the UpdateCMEmuVersion branch April 12, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

@dongkyunahn-intel dongkyunahn-intel dongkyunahn-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turinevgeny @dongkyunahn-intel @bader @v-klochkov