[SYCL] Force sycl::vec as device-copyable #9923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a type to be implicitly device-copyable in SYCL it must either be trivially-copyable or explicitly specialize `is_device_copyable`. Currently `sycl::vec` isn't the former due to a work-around in the copy ctor. However, this work-around should not have an effect on whether it can actually be copied to device. As such, this commit adds an explcit specialization of `is_device_copyable` for `vec` to stay in place until the copy ctor has been fixed. Signed-off-by: Larsen, Steffen <[email protected]>
0x12CC
approved these changes
Jun 15, 2023
cperkinsintel
approved these changes
Jun 15, 2023
|
This only fixes it for vec itself. But not for a struct (defined by the user) containing a vec. Therefore this doesn't seem like a good solution. |
Good point. This was only intended as a temporary solution, but you are right that it might not solve all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a type to be implicitly device-copyable in SYCL it must either be trivially-copyable or explicitly specialize
is_device_copyable. Currentlysycl::vecisn't the former due to a work-around in the copy ctor. However, this work-around should not have an effect on whether it can actually be copied to device. As such, this commit adds an explcit specialization ofis_device_copyableforvecto stay in place until the copy ctor has been fixed.