Skip to content

[SYCL] Force sycl::vec as device-copyable #9923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SYCL] Force sycl::vec as device-copyable #9923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30e068
[SYCL] Force sycl::vec as device-copyable
steffenlarsen Jun 15, 2023
538098b
Merge remote-tracking branch 'intel/sycl' into steffen/force_vec_devi…
steffenlarsen Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sycl/include/sycl/types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2352,6 +2352,16 @@ struct is_device_copyable<T[N],
std::enable_if_t<!std::is_trivially_copyable_v<T>>>
: is_device_copyable<T> {};

// sycl::vec is not currently trivially move-constructible due to a work-around.
// It should still be safe to copy it to device, however, so we specialize
// is_device_copyable for it as a work-around.
// TODO: Remove this once sycl::vec is made trivially move-constructible.
template <typename T, int N>
struct is_device_copyable<
vec<T, N>, std::enable_if_t<is_device_copyable<T>::value &&
!std::is_trivially_copyable_v<vec<T, N>>>>
: std::true_type {};

template <typename T>
struct is_device_copyable<
T, std::enable_if_t<!std::is_trivially_copyable_v<T> &&
Expand Down
68 changes: 68 additions & 0 deletions sycl/test/basic_tests/implicit_device_copyable_types.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,74 @@ int main() {
#endif
static_assert(sycl::is_device_copyable_v<const sycl::span<int>>);

// sycl::vec
static_assert(sycl::is_device_copyable_v<sycl::vec<int8_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<uint8_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<int16_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<uint16_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<int32_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<uint32_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<int64_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<uint64_t, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<sycl::half, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<float, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::vec<double, 1>>);
static_assert(sycl::is_device_copyable_v<sycl::char2>);
static_assert(sycl::is_device_copyable_v<sycl::uchar2>);
static_assert(sycl::is_device_copyable_v<sycl::short2>);
static_assert(sycl::is_device_copyable_v<sycl::ushort2>);
static_assert(sycl::is_device_copyable_v<sycl::int2>);
static_assert(sycl::is_device_copyable_v<sycl::uint2>);
static_assert(sycl::is_device_copyable_v<sycl::long2>);
static_assert(sycl::is_device_copyable_v<sycl::ulong2>);
static_assert(sycl::is_device_copyable_v<sycl::half2>);
static_assert(sycl::is_device_copyable_v<sycl::float2>);
static_assert(sycl::is_device_copyable_v<sycl::double2>);
static_assert(sycl::is_device_copyable_v<sycl::char3>);
static_assert(sycl::is_device_copyable_v<sycl::uchar3>);
static_assert(sycl::is_device_copyable_v<sycl::short3>);
static_assert(sycl::is_device_copyable_v<sycl::ushort3>);
static_assert(sycl::is_device_copyable_v<sycl::int3>);
static_assert(sycl::is_device_copyable_v<sycl::uint3>);
static_assert(sycl::is_device_copyable_v<sycl::long3>);
static_assert(sycl::is_device_copyable_v<sycl::ulong3>);
static_assert(sycl::is_device_copyable_v<sycl::half3>);
static_assert(sycl::is_device_copyable_v<sycl::float3>);
static_assert(sycl::is_device_copyable_v<sycl::double3>);
static_assert(sycl::is_device_copyable_v<sycl::char4>);
static_assert(sycl::is_device_copyable_v<sycl::uchar4>);
static_assert(sycl::is_device_copyable_v<sycl::short4>);
static_assert(sycl::is_device_copyable_v<sycl::ushort4>);
static_assert(sycl::is_device_copyable_v<sycl::int4>);
static_assert(sycl::is_device_copyable_v<sycl::uint4>);
static_assert(sycl::is_device_copyable_v<sycl::long4>);
static_assert(sycl::is_device_copyable_v<sycl::ulong4>);
static_assert(sycl::is_device_copyable_v<sycl::half4>);
static_assert(sycl::is_device_copyable_v<sycl::float4>);
static_assert(sycl::is_device_copyable_v<sycl::double4>);
static_assert(sycl::is_device_copyable_v<sycl::char8>);
static_assert(sycl::is_device_copyable_v<sycl::uchar8>);
static_assert(sycl::is_device_copyable_v<sycl::short8>);
static_assert(sycl::is_device_copyable_v<sycl::ushort8>);
static_assert(sycl::is_device_copyable_v<sycl::int8>);
static_assert(sycl::is_device_copyable_v<sycl::uint8>);
static_assert(sycl::is_device_copyable_v<sycl::long8>);
static_assert(sycl::is_device_copyable_v<sycl::ulong8>);
static_assert(sycl::is_device_copyable_v<sycl::half8>);
static_assert(sycl::is_device_copyable_v<sycl::float8>);
static_assert(sycl::is_device_copyable_v<sycl::double8>);
static_assert(sycl::is_device_copyable_v<sycl::char16>);
static_assert(sycl::is_device_copyable_v<sycl::uchar16>);
static_assert(sycl::is_device_copyable_v<sycl::short16>);
static_assert(sycl::is_device_copyable_v<sycl::ushort16>);
static_assert(sycl::is_device_copyable_v<sycl::int16>);
static_assert(sycl::is_device_copyable_v<sycl::uint16>);
static_assert(sycl::is_device_copyable_v<sycl::long16>);
static_assert(sycl::is_device_copyable_v<sycl::ulong16>);
static_assert(sycl::is_device_copyable_v<sycl::half16>);
static_assert(sycl::is_device_copyable_v<sycl::float16>);
static_assert(sycl::is_device_copyable_v<sycl::double16>);

// const
static_assert(sycl::is_device_copyable_v<const std::pair<int, float>>);
static_assert(sycl::is_device_copyable_v<const std::pair<ACopyable, float>>);
Expand Down