[SYCL] Change a check for a device compiler availability #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch we checked for a device compiler in
ProgramManager::build, but this function is called for AOT compiled
programs as well as required by the OpenCL specification:
clBuildProgram must be called for program created using either
clCreateProgramWithSource or clCreateProgramWithBinary to build
the program executable for one or more devices associated with
program.
Signed-off-by: Andrew Savonichev <[email protected]>
|
This patch does not have a proper a test, because every runtime in our testing has a compiler available. |
MrSidims
previously approved these changes
Jan 10, 2020
We can have a OpenCL 2.1 device but without a compiler. Signed-off-by: Andrew Savonichev <[email protected]>
romanovvlad
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we checked for a device compiler in
ProgramManager::build, but this function is called for AOT compiled
programs as well as required by the OpenCL specification:
Signed-off-by: Andrew Savonichev [email protected]