Skip to content

[SYCL] Change a check for a device compiler availability #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2020
Merged

[SYCL] Change a check for a device compiler availability #997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae7bd69
[SYCL] Change a check for a device compiler availability
Jan 9, 2020
3b8f7d7
Check for compiler before we check for 2.1
Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions sycl/source/detail/program_manager/program_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,23 +197,30 @@ static bool isDeviceBinaryTypeSupported(const context &C,
if (Format != PI_DEVICE_BINARY_TYPE_SPIRV)
return true;

vector_class<device> Devices = C.get_devices();

// Program type is SPIR-V, so we need a device compiler to do JIT.
for (const device &D : Devices) {
if (!D.get_info<info::device::is_compiler_available>())
return false;
}

// OpenCL 2.1 and greater require clCreateProgramWithIL
if (pi::useBackend(pi::SYCL_BE_PI_OPENCL) &&
C.get_platform().get_info<info::platform::version>() >= "2.1")
return true;

// Otherwise we need cl_khr_il_program extension to be present
// and we can call clCreateProgramWithILKHR using the extension
for (const device &D : C.get_devices()) {
for (const device &D : Devices) {
// We need cl_khr_il_program extension to be present
// and we can call clCreateProgramWithILKHR using the extension
vector_class<string_class> Extensions =
D.get_info<info::device::extensions>();
if (std::find(Extensions.begin(), Extensions.end(),
string_class("cl_khr_il_program")) != Extensions.end())
return true;
if (Extensions.end() ==
std::find(Extensions.begin(), Extensions.end(), "cl_khr_il_program"))
return false;
}

// This device binary type is not supported.
return false;
return true;
}

static const char *getFormatStr(RT::PiDeviceBinaryType Format) {
Expand Down Expand Up @@ -618,14 +625,6 @@ ProgramManager::build(ProgramPtr Program, RT::PiContext Context,
}
const char *Opts = std::getenv("SYCL_PROGRAM_BUILD_OPTIONS");

for (const auto &DeviceId : Devices) {
if (!createSyclObjFromImpl<device>(std::make_shared<device_impl>(DeviceId))
.get_info<info::device::is_compiler_available>()) {
throw feature_not_supported(
"Online compilation is not supported by this device");
}
}

if (!Opts)
Opts = Options.c_str();

Expand Down