Add CSP and other files to explorer #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjsjohnmurray
requested changes
Jun 29, 2020
There was a problem hiding this comment.
@ty-d how about fixing the linting warnings about missing return types in index.ts while you are touching it?
daimor
requested changes
Jun 29, 2020
| @@ -42,14 +51,20 @@ export class RootNode extends NodeBase { | |||
| spec = "*.cls"; | |||
| break; | |||
| case "RTN": | |||
| spec = "*.mac,*.int"; | |||
| spec = "*.mac,*.int,*.bas"; | |||
| @@ -61,10 +61,17 @@ export class DocumentContentProvider implements vscode.TextDocumentContentProvid | |||
| }); | |||
| } | |||
| } | |||
| const isCsp = name.split("/")[0] === "csp"; | |||
There was a problem hiding this comment.
No, that's not a rule. CSP application may have any name. You need a better way to check if it's a CSP.
src/explorer/models/rootNode.ts
Outdated
| case "CSP": | ||
| spec = "*"; | ||
| break; | ||
| case "OTHER": |
There was a problem hiding this comment.
OTHER replace everywhere with OTH, to be consistent with Atelier API
isc-rsingh
approved these changes
Jul 1, 2020
|
@daimor GitHub is saying you have requested changes, but I think your request has been addressed. Are we ready to merge this PR? |
daimor
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "CSP Files" and "Other" section to the ObjectScript explorer, and support compilation of those files. The studio actions editor context menu was modified to appear for CSP and other files.