initial support for server's settings from intersystems.servers #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daimor do you want this approved and merged now? |
|
Work in progress, it was happened to be a bit more complicated, than I thought. |
gjsjohnmurray
requested changes
Jul 3, 2020
package.json
Outdated
| }, | ||
| "server": { | ||
| "type": "string", | ||
| "pattern": "^[A-Za-z0-9-._~]+$", |
There was a problem hiding this comment.
I think we no longer allow uppercase characters in server names.
package.json
Outdated
| "server": { | ||
| "type": "string", | ||
| "pattern": "^[A-Za-z0-9-._~]+$", | ||
| "markdownDescription": "Server defined in `intersystems.servers`" |
There was a problem hiding this comment.
Make this
`#intersystems.servers#`
and it will hyperlink to that part of Settings.
src/commands/serverActions.ts
Outdated
| if (workspaceState.get(workspaceFolder + ":docker", true)) { | ||
| terminal.push({ | ||
| if (workspaceState.get(workspaceFolder + ":docker", false)) { | ||
| actions.push({ | ||
| id: "openDockerTerminal", | ||
| label: "Open terminal in docker", |
There was a problem hiding this comment.
"Open Terminal in Docker"
Co-authored-by: John Murray <[email protected]>
gjsjohnmurray
requested changes
Jul 3, 2020
package.json
Outdated
| @@ -558,29 +558,29 @@ | |||
| "description": "Password of username. If not set here it must be provided when connecting." | |||
| }, | |||
| "https": { | |||
| "description": "Use SSL to access to API", | |||
| "description": "Use SSL to access to API.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Use SSL to access to API.", | |
| "description": "Use SSL/TLS to access the server.", |
gjsjohnmurray
requested changes
Jul 6, 2020
isc-rsingh
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.