Make ServerManager extension as optional, do not prevent this extension working. #188
Conversation
daimor
force-pushed
the
servermanager_optional
branch
from
3ad0f7d to
7effe96
Compare
There was a problem hiding this comment.
@daimor are you only removing the extensionDependency because it is causing a problem with your CI pipeline. Isn't there another way of solving this? It seems an unnecessary complication for the user to be given this choice the first time they install. Why would they not be willing to receive the intersystems-community.servermanager helper extension automatically and silently?
But in case the verdict is that the simple extensionDependency isn't acceptable I have requested a few changes to your alternative mechanism.
src/extension.ts
Outdated
| case "Install": | ||
| await vscode.commands.executeCommand("workbench.extensions.installExtension", extId); | ||
| // eslint-disable-next-line no-fallthrough | ||
| case "View": |
There was a problem hiding this comment.
showInformationMessage doesn't offer "View" option
There was a problem hiding this comment.
My thoughts were, do not offer too many buttons, and was not sure if it's a good idea to install it from information message, not from extension page
There was a problem hiding this comment.
In which case why is case "View": here?
|
This extension still can work without servermanager, but with extensiondependency, it does not work at all, until servermanager installed. And it’s not silently, it asks user for installation approval. |
Co-authored-by: John Murray <[email protected]>
resolves #187