Skip to content

Show system items in ObjectScript Explorer view #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

daimor
Copy link
Member

@daimor daimor commented Jul 7, 2020

closes #165

@@ -401,6 +409,16 @@
"title": "Hide Generated",
"category": "ObjectScript"
},
{
"command": "vscode-objectscript.explorer.showSystem",
"title": "Show System",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since %Z classes aren't system classes, I suggest this menu item name be "Show % Classes"

reference: https://docs.intersystems.com/irislatest/csp/docbook/Doc.View.cls?KEY=GORIENT_appx_identifiers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%ZEN also %Z

},
{
"command": "vscode-objectscript.explorer.hideSystem",
"title": "Hide System",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since %Z classes aren't system classes, I suggest this menu item name be "Hide % Classes"

reference: https://docs.intersystems.com/irislatest/csp/docbook/Doc.View.cls?KEY=GORIENT_appx_identifiers

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to clarify, this feature only applies to ObjectScript Explorer, right? If so, maybe make that clear in the PR title.

@isc-rsingh
Copy link
Member

LGTM. Just to clarify, this feature only applies to ObjectScript Explorer, right? If so, maybe make that clear in the PR title.

Good point @gjsjohnmurray. @daimor would it make sense to have the same capability with the ISFS view?

@isc-rsingh isc-rsingh changed the title Show system items in explorer view Show system items in ObjectScript Explorer view Jul 8, 2020
@daimor
Copy link
Member Author

daimor commented Jul 8, 2020

isfs has much more capabilities, it can redefine namespace, use filters and types of files
https://github.com/intersystems-community/vscode-objectscript/wiki/Server-side-editing

@isc-rsingh
Copy link
Member

isfs has much more capabilities, it can redefine namespace, use filters and types of files
https://github.com/intersystems-community/vscode-objectscript/wiki/Server-side-editing

So isfs already has the capability to do this via manual filters.

@daimor I don't know why the build is failing...

@daimor
Copy link
Member Author

daimor commented Jul 8, 2020

it can't test extension due to dependency, the extension can't run if no dependency resolved. will be good after merge #188

Copy link
Member

@isc-rsingh isc-rsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to force a build

@isc-rsingh isc-rsingh closed this Jul 9, 2020
@isc-rsingh isc-rsingh reopened this Jul 9, 2020
@isc-rsingh isc-rsingh merged commit 24f51fc into master Jul 9, 2020
@daimor daimor deleted the #165-explorer_show_system branch July 28, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"System" classes in non %SYS namespaces are not visible
4 participants