-
Notifications
You must be signed in to change notification settings - Fork 48
Show system items in ObjectScript Explorer view #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -401,6 +409,16 @@ | |||
"title": "Hide Generated", | |||
"category": "ObjectScript" | |||
}, | |||
{ | |||
"command": "vscode-objectscript.explorer.showSystem", | |||
"title": "Show System", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since %Z classes aren't system classes, I suggest this menu item name be "Show % Classes"
reference: https://docs.intersystems.com/irislatest/csp/docbook/Doc.View.cls?KEY=GORIENT_appx_identifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%ZEN also %Z
}, | ||
{ | ||
"command": "vscode-objectscript.explorer.hideSystem", | ||
"title": "Hide System", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since %Z classes aren't system classes, I suggest this menu item name be "Hide % Classes"
reference: https://docs.intersystems.com/irislatest/csp/docbook/Doc.View.cls?KEY=GORIENT_appx_identifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just to clarify, this feature only applies to ObjectScript Explorer, right? If so, maybe make that clear in the PR title.
Good point @gjsjohnmurray. @daimor would it make sense to have the same capability with the ISFS view? |
isfs has much more capabilities, it can redefine namespace, use filters and types of files |
So isfs already has the capability to do this via manual filters. @daimor I don't know why the build is failing... |
it can't test extension due to dependency, the extension can't run if no dependency resolved. will be good after merge #188 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to force a build
closes #165