[telemetry] add nix.version to sentry and segment #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
gcurtis
approved these changes
Sep 12, 2023
savil
added a commit
that referenced
this pull request
Oct 18, 2023
## Summary `newSentryException` can error [here](https://github.com/jetpack-io/devbox/blob/main/internal/telemetry/sentry.go#L55) due to `err` being `nil`. Its only callsite is [here](https://github.com/jetpack-io/devbox/blob/main/internal/telemetry/telemetry.go#L130), but the `nix.Version` above is resetting the `err` to `nil` leading to a segfault. This was my bad from #1469 In this PR, I change the variable `err` to `errToLog` so that any of us adding other code here do not accidentally clobber the `errToLog` variable. I think but not sure this is the cause of #1562 (but not sure). ## How was it tested? I managed to get a repro with the nginx example and running `devbox` version 0.6, and doing `devbox services up -b`, when the services are already running leading to an error. When I run it with the new `devbox` binary, it errors correctly without a segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upon request by @Lagoja, this PR adds nix-version information to the sentry and segment telemetry logging.
How was it tested?
Added a sentryDSN and telemetryKey locally, and built the binary.
Added a print-statement to verify the nix-version in the commandEvent to segment is correctly set for me.