Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
newSentryException
can error here due toerr
beingnil
. Its only callsite is here, but thenix.Version
above is resetting theerr
tonil
leading to a segfault.This was my bad from #1469
In this PR, I change the variable
err
toerrToLog
so that any of us adding other code here do not accidentally clobber theerrToLog
variable.I think but not sure this is the cause of #1562 (but not sure).
How was it tested?
I managed to get a repro with the nginx example and running
devbox
version 0.6, and doingdevbox services up -b
, when the services are already running leading to an error.When I run it with the new
devbox
binary, it errors correctly without a segfault.