-
Notifications
You must be signed in to change notification settings - Fork 249
[plugins] Fix init hooks for custom plugins #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,10 @@ func WriteScriptsToFiles(devbox devboxer) error { | |
|
||
// Write all hooks to a file. | ||
written := map[string]struct{}{} // set semantics; value is irrelevant | ||
pluginHooks, err := plugin.InitHooks(devbox.InstallablePackages(), devbox.ProjectDir()) | ||
pluginHooks, err := devbox.PluginManager().InitHooks( | ||
devbox.InstallablePackages(), | ||
devbox.Config().Include, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: should this field be plural: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this ship has sailed, has been in the FWIW, I think we chatted about this an decided to use as a verb instead of noun (similar to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh yeah, I do remember chatting about it being a verb... |
||
) | ||
if err != nil { | ||
return errors.WithStack(err) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fix indent. Same for line 7