[perf UX] add spinner to print-dev-env output #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
savil
force-pushed
the
savil/print-dev-env-output
branch
from
57d6660 to
afe7790
Compare
mikeland73
approved these changes
Oct 10, 2023
internal/impl/devbox.go
Outdated
Comment on lines
789
to
790
| spinny.FinalMSG = "✓ Got env-vars from nix.\n" | ||
| spinny.Suffix = " Getting env-vars from nix...\n" |
There was a problem hiding this comment.
Computing new devbox environment...
...
Devbox environment computed
?
There was a problem hiding this comment.
Yeah, we could do that. I was trying to indicate to the user that this is nix being slow (which it is, in this instance) 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a nice spinner while we get a result from nix
How was it tested?
Spinning state:
Final state:
