Skip to content

[envsec] Add (hidden) envsec init command #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions devbox.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
],
"code": "code .",
"lint": "golangci-lint run --timeout 5m && scripts/gofumpt.sh",
"fmt": "scripts/gofumpt.sh",
"test": "go test -race -cover ./...",
"update-examples": "devbox run build && go run testscripts/testrunner/updater/main.go"
}
Expand Down
58 changes: 58 additions & 0 deletions internal/boxcli/envsec.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
// Copyright 2023 Jetpack Technologies Inc and contributors. All rights reserved.
// Use of this source code is governed by the license in the LICENSE file.

package boxcli

import (
"github.com/pkg/errors"
"github.com/spf13/cobra"
"go.jetpack.io/devbox"
"go.jetpack.io/devbox/internal/impl/devopt"
"go.jetpack.io/devbox/internal/integrations/envsec"
)

type envsecInitCmdFlags struct {
config configFlags
}

func envsecCmd() *cobra.Command {
cmd := &cobra.Command{
Use: "envsec",
Short: "envsec commands",
}
cmd.AddCommand(envsecInitCmd())
cmd.Hidden = true
return cmd
}

func envsecInitCmd() *cobra.Command {
flags := envsecInitCmdFlags{}
cmd := &cobra.Command{
Use: "init",
Short: "initialize envsec integration",
Args: cobra.ExactArgs(0),
RunE: func(cmd *cobra.Command, args []string) error {
return envsecInitFunc(cmd, flags)
},
}

flags.config.register(cmd)

return cmd
}

func envsecInitFunc(cmd *cobra.Command, flags envsecInitCmdFlags) error {
box, err := devbox.Open(&devopt.Opts{
Dir: flags.config.path,
Stderr: cmd.ErrOrStderr(),
})
if err != nil {
return errors.WithStack(err)
}
if err := envsec.EnsureInitialized(
cmd.Context(), box.ProjectDir()); err == nil {
return nil
}
box.Config().SetStringField("EnvFrom", "envsec")
return box.Config().SaveTo(box.ProjectDir())
}
1 change: 1 addition & 0 deletions internal/boxcli/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ func RootCmd() *cobra.Command {
command.AddCommand(authCmd())
}
command.AddCommand(createCmd())
command.AddCommand(envsecCmd())
command.AddCommand(generateCmd())
command.AddCommand(globalCmd())
command.AddCommand(infoCmd())
Expand Down
5 changes: 3 additions & 2 deletions internal/devconfig/env.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ package devconfig

import (
"context"
"fmt"
"os"

"go.jetpack.io/devbox/internal/boxcli/usererr"
"go.jetpack.io/devbox/internal/integrations/envsec"
"go.jetpack.io/devbox/internal/ux"
)

func (c *Config) ComputedEnv(
Expand All @@ -18,7 +18,8 @@ func (c *Config) ComputedEnv(
if c.IsEnvsecEnabled() {
env, err = envsec.Env(ctx, projectDir)
if err != nil {
fmt.Fprintf(os.Stderr, "Error reading secrets from envsec: %s\n\n", err)
ux.Fwarning(os.Stderr, "Error reading secrets from envsec: %s\n\n", err)
env = map[string]string{}
}
} else if c.EnvFrom != "" {
return nil, usererr.New("unknown from_env value: %s", c.EnvFrom)
Expand Down
56 changes: 56 additions & 0 deletions internal/devconfig/field.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
package devconfig

import (
"reflect"
"strings"

"github.com/tailscale/hujson"
)

func (c *Config) SetStringField(fieldName, val string) {
valueOfStruct := reflect.ValueOf(c).Elem()

field := valueOfStruct.FieldByName(fieldName)
field.SetString(val)

c.ast.setStringField(c.jsonNameOfField(fieldName), val)
}

func (c *Config) jsonNameOfField(fieldName string) string {
valueOfStruct := reflect.ValueOf(c).Elem()

var name string
for i := 0; i < valueOfStruct.NumField(); i++ {
field := valueOfStruct.Type().Field(i)
if field.Name != fieldName {
continue
}

name = field.Name
jsonTag := field.Tag.Get("json")
parts := strings.Split(jsonTag, ",")
if len(parts) > 0 && parts[0] != "" && parts[0] != "-" {
name = parts[0]
}

break
}
return name
}

func (c *configAST) setStringField(key, val string) {
rootObject := c.root.Value.(*hujson.Object)
i := c.memberIndex(rootObject, key)
if i == -1 {
rootObject.Members = append(rootObject.Members, hujson.ObjectMember{
Name: hujson.Value{Value: hujson.String(key)},
Value: hujson.Value{Value: hujson.String(val)},
})
} else if val != "" {
rootObject.Members[i].Value = hujson.Value{Value: hujson.String(val)}
} else {
rootObject.Members = append(rootObject.Members[:i], rootObject.Members[i+1:]...)
}

c.root.Format()
}
4 changes: 2 additions & 2 deletions internal/integrations/envsec/envsec.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func Env(ctx context.Context, projectDir string) (map[string]string, error) {
return envCache, nil
}

if err := ensureInitialized(ctx, projectDir); err != nil {
if err := EnsureInitialized(ctx, projectDir); err != nil {
return nil, err
}

Expand Down Expand Up @@ -58,7 +58,7 @@ func EnsureInstalled(ctx context.Context) (string, error) {
return binPathCache, nil
}

func ensureInitialized(ctx context.Context, projectDir string) error {
func EnsureInitialized(ctx context.Context, projectDir string) error {
binPath, err := EnsureInstalled(ctx)
if err != nil {
return err
Expand Down