This repository was archived by the owner on Jul 9, 2023. It is now read-only.
Merge to beta #605
Merged
Merge to beta #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for an unknown reason. In any case, this code is easier to read.
… for an unknown reason. In any case, this code is easier to read.
Memory Leak Fix
…e wpf test project (invalid cast exception)
typo fixes, add some missing xml comment for method arguments, fix the wpf test project (invalid cast exception)
prepare for basic http/2 support and another small fixes (typo, version numbers)
…e flag: - only enabled when both client and server supports it (no protocol changing in proxy) - GetRequest/ResponseBody(AsString) methods are not supported - cannot modify the request/response (e.g header modifications in BeforeRequest/Response events are ignored)
…eded anymore, so I remove it.
Basic HTTP/2 support. Disabled by default. Warning added to the enabl…
(still not able to modify header or body data)
Add a new property (RequestUriString) which can be overridden in user code
Small HTTP/2 and other improvements
…exception in Dispose
…y TWP only, which also needs 2.0) => Allow to consolidate nuget packages.
nuget package consolidation
allow to modify HTTP/2 header
…ing on PeekByteAsync
…ufferpool (to get the best of the two worlds)
…ing on PeekByteAsync
…ufferpool (to get the best of the two worlds)
--------------------------- //1st clientStream var clientStream = new CustomBufferedStream(clientConnection.GetStream(), BufferPool, BufferSize); sslStream = new SslStream(clientStream, false); //false => do not dispose 1st ClientStream //2nd clientStream clientStream = new CustomBufferedStream(sslStream, BufferPool, BufferSize); ... sslStream?.Dispose(); // dispose sslStream but not 1st ClientStream clientStream.Dispose(); // dispose 2nd ClientStream, sslStream (already disposed) //here 1st clientStream is not disposed ---------------------------
CustomBufferedStream were not disposed
…e SslStream), only throwing an exception can fix that behavior. - BeginWrite was not correct, we should call this.WriteAsync instead of baseStream.WriteAsync rewritten
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doneness: