Skip to content

✨ update logical cluster version #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pradeepnnv
Copy link

Update logical cluster version.
Fixes #18.

@ncdc
Copy link
Member

ncdc commented Jul 27, 2022

Thanks! You'll also need to update all the .go files currently importing github.com/kcp-dev/logicalcluster and change it to github.com/kcp-dev/logicalcluster/v2

@ncdc
Copy link
Member

ncdc commented Jul 27, 2022

And then please run go mod tidy 😄

Signed-off-by: pradeepnnv <[email protected]>
@pradeepnnv
Copy link
Author

Updated the PR with the actual code changes now. @ncdc , please review.

@ncdc
Copy link
Member

ncdc commented Jul 28, 2022

Thanks @pradeepnnv, we need to do a bit of housekeeping to create a new branch that matches the current state of kcp main, which is based on Kubernetes v1.24.x. Let me do that first, and then would you mind retargeting that new branch?

@pradeepnnv
Copy link
Author

Sure. I'll wait for the new branch to be available.

@ncdc
Copy link
Member

ncdc commented Aug 8, 2022

@pradeepnnv so sorry but we ended up needing to pull this change into the 1.24 rebase PR, but we 💯 appreciate you offering to help out. Hopefully you'll find future opportunities!

Replaced by #21

/close

@openshift-ci openshift-ci bot closed this Aug 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

@ncdc: Closed this PR.

In response to this:

@pradeepnnv so sorry but we ended up needing to pull this change into the 1.24 rebase PR, but we 💯 appreciate you offering to help out. Hopefully you'll find future opportunities!

Replaced by #21

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to logicalcluster v2
2 participants