Skip to content

Extend numpy recipe to support python3 #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

krinnewitz
Copy link
Contributor

@krinnewitz krinnewitz commented Aug 28, 2018

This PR extends the existing numpy recipe to also support
python3crystax. Additionally, the existing recipe code is cleaned up a
bit and numpy is upgraded to version 1.15.1.

The existing patches were ported to the new numpy version.
To get numpy 1.15.1 working with python 2.7, an additional patch
was necessary.

This PR should resolve #882.

This patch extends the existing numpy recipe to also support
python3crystax. Additionally, the existing recipe code is cleaned up a
bit and numpy is upgraded to version 1.15.1.
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! It's looking good to me. But I didn't yet get a chance to actually try it on device.
Also the build is still passing for python2 + numpy.
By the way it would be great to add python3 + numpy support to the continuous integration. But that can be tackled in a different pull request.
Also at some point we should think about slowly dropping python2 support.

I approve the PR, but won't merge it unless somebody else confirms it's working on device. If nobody does I'll take time later to check it. Otherwise ping us again :)

@krinnewitz
Copy link
Contributor Author

Thanks so far @AndreMiras. Since no one has picked up on this, yet - here is a very simple program that can be used as a quick starting point:

import sys
print ('sys.version is', sys.version)

import numpy as np
a = np.arange(15).reshape(3, 5)
print('numpy seems to work:\n', a)

@AndreMiras AndreMiras merged commit 333a323 into kivy:master Sep 3, 2018
@AndreMiras
Copy link
Member

Thanks for the reminder, merged!

@AntoniRomera
Copy link

Hi, when i use this code, i got the next error:

x86_64-linux-gnu-gcc: error: unrecognized command line option '-mfloat-abi=softfp'
x86_64-linux-gnu-gcc: error: unrecognized command line option '-mfpu=vfp'
x86_64-linux-gnu-gcc: error: unrecognized command line option '-mthumb'
x86_64-linux-gnu-gcc: error: unrecognized command line option '-mfloat-abi=softfp'
x86_64-linux-gnu-gcc: error: unrecognized command line option '-mfpu=vfp'
x86_64-linux-gnu-gcc: error: unrecognized command line option '-mthumb'

@JohnBuckleyGitHub
Copy link

First of all thank you very much to krinnewitz for getting the Python 3 build going. It has been an open ticket for so long.

As it seems python3crystax is being dropped in favor of python3 (Google NDK). The numpy recipe only has python2 and python3crystax. Does the recipe use any functions that are specific to crystax?

@krinnewitz
Copy link
Contributor Author

I think porting/extending the recipe for google NDK's python3 shouldn't be a problem.

@JohnBuckleyGitHub
Copy link

JohnBuckleyGitHub commented Dec 31, 2018 via email

@AndreMiras
Copy link
Member

@johnbolia start a "WIP" pull request that try the fix and share your problem in that dedicated PR, we can also give support on Discord to help you building it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy support w/ python3crystax
5 participants