Skip to content

Add recipes for OpenAL support #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Conversation

krinnewitz
Copy link
Contributor

@krinnewitz krinnewitz commented Sep 3, 2018

This PR adds recipes for PyOpenAL, OpenAL Soft, PyOgg, libvorbis, and libogg.

Note: A working numpy recipe is needed. So for testing with python3, you also need to pull in #1343.

AndreMiras
AndreMiras previously approved these changes Sep 3, 2018
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of minor comments, but it looks overall good to me.
I'll check later this week if it compiles on my laptop and merge if it does.
Thanks, keep up the good work 😄

AndreMiras
AndreMiras previously approved these changes Sep 3, 2018
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update addressing some of the minor comments I had.
Don't you think it would make sense to squash as a single commit?

@krinnewitz
Copy link
Contributor Author

Yes, squashing is fine with me. I will do that in a second.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks again.
I'll try to see if it at least compiles and merge it this week. If I don't please ping me again.

@AndreMiras
Copy link
Member

It compiled fine on CrystaX, but didn't try to play with an actual app.
Here's the proof:

buildozer android debug
...
[INFO]:    Using Crystax NDK r9c
[INFO]:    Found virtualenv at /home/andre/.local/bin/virtualenv
[INFO]:    Found the following toolchain versions: ['4.9', '5', 'clang3.6', 'clang3.7']
[INFO]:    Picking the latest gcc toolchain, here 5
[INFO]:    Of the existing distributions, the following meet the given requirements:
[INFO]:         pr1348: includes recipes (hostpython3crystax, libogg, libvorbis, openal, sdl2_image, sdl2_mixer, sdl2_ttf, python3crystax, numpy, sdl2, setuptools, six, pyjnius, pyogg, pyopenal, kivy), built for archs (armeabi-v7a)
[INFO]:    pr1348 has compatible recipes, using this one
[INFO]:    Of the existing distributions, the following meet the given requirements:
[INFO]:         pr1348: includes recipes (hostpython3crystax, libogg, libvorbis, openal, sdl2_image, sdl2_mixer, sdl2_ttf, python3crystax, numpy, sdl2, setuptools, six, pyjnius, pyogg, pyopenal, kivy), built for archs (armeabi-v7a)
[INFO]:    pr1348 has compatible recipes, using this one
[INFO]:    -> directory context /home/andre/workspace/test/.buildozer/android/platform/build/dists/pr1348
[INFO]:    Selecting java build tool:
[INFO]:    Detected highest available build tools version to be 28.0.2
[INFO]:        Building with gradle, as gradle executable is present
[DEBUG]:   -> running gradlew assembleDebug
[DEBUG]:        Incremental java compilation is an incubating feature.
[DEBUG]:        :preBuild UP-TO-DATE
[DEBUG]:        :preDebugBuild UP-TO-DATE
[DEBUG]:        :checkDebugManifest
[DEBUG]:        :prepareDebugDependencies
[DEBUG]:        :compileDebugAidl
[DEBUG]:        :compileDebugRenderscript
[DEBUG]:        :generateDebugBuildConfig
[DEBUG]:        :generateDebugResValues
[DEBUG]:        :generateDebugResources
[DEBUG]:        :mergeDebugResources
[DEBUG]:        :processDebugManifest
[DEBUG]:        :processDebugResources
[DEBUG]:        :generateDebugSources
[DEBUG]:        :incrementalDebugJavaCompilationSafeguard
[DEBUG]:        :javaPreCompileDebug
[DEBUG]:        :compileDebugJavaWithJavac
[DEBUG]:        :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
[DEBUG]:        Note: Some input files use or override a deprecated API.
[DEBUG]:        Note: Recompile with -Xlint:deprecation for details.
[DEBUG]:        :compileDebugNdk UP-TO-DATE
[DEBUG]:        :compileDebugSources
[DEBUG]:        :mergeDebugShaders
[DEBUG]:        :compileDebugShaders
[DEBUG]:        :generateDebugAssets
[DEBUG]:        :mergeDebugAssets
[DEBUG]:        :transformClassesWithDexForDebug
[DEBUG]:
[DEBUG]:        Running dex as a separate process.
[DEBUG]:
[DEBUG]:        To run dex in process, the Gradle daemon needs a larger heap.
[DEBUG]:        It currently has 1024 MB.
[DEBUG]:        For faster builds, increase the maximum heap size for the Gradle daemon to at least 1536 MB.
[DEBUG]:        To do this set org.gradle.jvmargs=-Xmx1536M in the project gradle.properties.
[DEBUG]:        For more information see https://docs.gradle.org/current/userguide/build_environment.html
[DEBUG]:
[DEBUG]:        :mergeDebugJniLibFolders
[DEBUG]:        :transformNativeLibsWithMergeJniLibsForDebug
[DEBUG]:        :transformNativeLibsWithStripDebugSymbolForDebug
[DEBUG]:        :processDebugJavaRes UP-TO-DATE
[DEBUG]:        :transformResourcesWithMergeJavaResForDebug
[DEBUG]:        :validateSigningDebug
[DEBUG]:        :packageDebug
[DEBUG]:        :assembleDebug
[DEBUG]:
[DEBUG]:        BUILD SUCCESSFUL
[DEBUG]:
[DEBUG]:        Total time: 3.495 secs
[DEBUG]:
[INFO]:    <- directory context /home/andre/workspace/test/.buildozer/android/platform/python-for-android-new-toolchain
[INFO]:    # Copying APK to current directory
[INFO]:    # APK filename not found in build output, trying to guess
[INFO]:    # Found APK file: /home/andre/workspace/test/.buildozer/android/platform/build/dists/pr1348/build/outputs/apk/pr1348-debug.apk
[INFO]:    # Add version number to APK
[INFO]:    # APK renamed to pr1348-0.1-debug.apk
[DEBUG]:   -> running cp /home/andre/workspace/test/.buildozer/android/platform/build/dists/pr1348/build/outputs/apk/pr1348-debug.apk pr1348-0.1-debug.apk
Could not find hostpython, will not compile to .pyo (this is normal with python3)
No compiled python is present to zip, skipping.
this should only be the case if you are using the CrystaX python
# Android packaging done!
# APK pr1348-0.1-debug.apk available in the bin directory
[andre:~/workspace/test] 1m28s $

@AndreMiras AndreMiras merged commit 0dc7664 into kivy:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants