-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add recipes for OpenAL support #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of minor comments, but it looks overall good to me.
I'll check later this week if it compiles on my laptop and merge if it does.
Thanks, keep up the good work 😄
f085922
to
d5df06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update addressing some of the minor comments I had.
Don't you think it would make sense to squash as a single commit?
Yes, squashing is fine with me. I will do that in a second. |
d5df06b
to
13f7a97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks again.
I'll try to see if it at least compiles and merge it this week. If I don't please ping me again.
It compiled fine on CrystaX, but didn't try to play with an actual app.
|
This PR adds recipes for PyOpenAL, OpenAL Soft, PyOgg, libvorbis, and libogg.
Note: A working numpy recipe is needed. So for testing with python3, you also need to pull in #1343.