Force delete lb when deletion_protection is disabled

[oliviassss]

Issue

#1900

Description

This PR is to handle the deletion_protection.enabled for both ALB and NLB.

• If deletion_protection.enabled=true is in the annotation and the customer deletes the load balancer, the controller will return error right away and refuse to reconcile further
• Once the attribute gets edited to deletion_protection.enabled=false, the deployer will call ModifyLoadBalancerAttributes() to disable the deletion_protection, so it can continue to delete the resource.

Tests:

• Created NLB, with deletion_protection.enabled=true, verified the service controller will return error and stop reconciling.
• Then edited the attributes using kubectl edit svc/<my-svc> -n <my-namespace>, to set deletion_protection.enabled=false, verified the deployer will disable the deletion_protection and the resource got deleted.
• Created ALB, with deletion_protection.enabled=true, verified the group controller will return error and stop reconciling.
• Then edited the attributes using kubectl edit ingress/<my-ingress> -n <my-namespace>, to set deletion_protection.enabled=false, verified the deployer will disable the deletion_protection and the resource got deleted.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Hi @oliviassss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tanvp112]

@oliviassss, how do you set deletion_protection.enable=true for a nlb? alb.ingress.kubernetes.io/load-balancer-attributes is an annotation for ingress (does not support NLB) and not service. Can you shade a light here?

[kishorj]

@oliviassss, how do you set deletion_protection.enable=true for a nlb? alb.ingress.kubernetes.io/load-balancer-attributes is an annotation for ingress (does not support NLB) and not service. Can you shade a light here?

The deletion protection will be supported for NLB in the upcoming v2.3.0 release (PR #2051).

[oliviassss]

@tanvp112 You can add this annotation in the yaml file to enable deletion_protection for NLB: service.beta.kubernetes.io/aws-load-balancer-attributes: deletion_protection.enabled=true. Check this link

[kishorj]

/ok-to-test

[kishorj]

With the proposed change, I see that if delete protection is not specified via annotation, but set on the NLB out-of-band, controller still force deletes the underlying NLB. This is contrary to the current design where controller doesn't nodify attributes not explicitly specified. This is a corner case, I agree, but lets see if it would make more sense to block the service deletion.

[codecov-commenter]

Codecov Report

Merging #2172 (dae2125) into main (f861a8e) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2172      +/-   ##
==========================================
- Coverage   52.34%   52.24%   -0.11%     
==========================================
  Files         132      132              
  Lines        7189     7203      +14     
==========================================
  Hits         3763     3763              
- Misses       3137     3151      +14     
  Partials      289      289              

Impacted Files	Coverage Δ
pkg/deploy/elbv2/load_balancer_synthesizer.go	41.37% <0.00%> (-7.94%)	⬇️
pkg/service/model_builder.go	93.75% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f861a8e...dae2125. Read the comment docs.

[oliviassss]

With the proposed change, I see that if delete protection is not specified via annotation, but set on the NLB out-of-band, controller still force deletes the underlying NLB. This is contrary to the current design where controller doesn't nodify attributes not explicitly specified. This is a corner case, I agree, but lets see if it would make more sense to block the service deletion.

According to our internal discussion, we will keep the method as it is now, and record this corner case situation in our documentation properly.

[kishorj]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment