fix error handling of load balancer deletion

[bitoku]

Issue

When a load balancer is deleted in LoadBalancerSynthesizer, errors other than "OperationNotPermitted: deletion protection" is ignored due to this change(#2172).
This change make the synthesizer return other errors as well.

Description

When a load balancer is associated with VPC endpoint service, deletion would fail with ResourceInUse error.
However it can't catch the error and continue to delete other resources.
I think it should be failed otherwise other resources such as targetgroupbindings will be deleted.

I'm not sure how to test synthesize method because there are no tests about it.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: bitoku / name: Ayato Tokubi (5e23b62)

[k8s-ci-robot]

Hi @bitoku. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kishorj]

/ok-to-test

[codecov-commenter]

Codecov Report

Base: 54.04% // Head: 54.03% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5e23b62) compared to base (bdb42ea).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
- Coverage   54.04%   54.03%   -0.02%     
==========================================
  Files         144      144              
  Lines        8223     8225       +2     
==========================================
  Hits         4444     4444              
- Misses       3461     3463       +2     
  Partials      318      318              

Impacted Files	Coverage Δ
pkg/deploy/elbv2/load_balancer_synthesizer.go	40.90% <0.00%> (-0.96%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kishorj]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment