-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add load balancer attributes support for IngressClassParams #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add load balancer attributes support for IngressClassParams #2190
Conversation
Hi @oliviassss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
+ Coverage 52.29% 52.36% +0.06%
==========================================
Files 132 133 +1
Lines 7234 7253 +19
==========================================
+ Hits 3783 3798 +15
- Misses 3157 3158 +1
- Partials 294 297 +3
Continue to review full report at Codecov.
|
f452eeb
to
d580df9
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is there a timeframe for when this is likely to be released? |
…es-sigs#2190) * add load balancer attributes support for IngressClassParams * format
Description
This PR adds an optional setting loadBalancerAttributes for IngressClassParams, to specify the ALB attributes to apply for all Ingresses of the IngressClass.
Tests
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯