Skip to content

Bump pdb apiVersion to v1 #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Bump pdb apiVersion to v1 #2192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
256dd57
Bump pdb apiVersion
Evalle Aug 25, 2021
5bbeb61
add if-else flow
Evalle Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm/aws-load-balancer-controller/templates/pdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{{- if and .Values.podDisruptionBudget (gt (int .Values.replicaCount) 1) }}
{{- if .Capabilities.APIVersions.Has "policy/v1" }}
apiVersion: policy/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 is stable as of k8s 1.21. We'd still need to be backwards compatible with older k8s version for the time being.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishorj thanks for the comment. What's the procedure here? Add some condition?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the .Capabilities.APIVersions.Has to use v1 if support is available, and fall back to v1beta1 otherwise?

{{- else }}
apiVersion: policy/v1beta1
{{- end }}
kind: PodDisruptionBudget
metadata:
name: {{ include "aws-load-balancer-controller.fullname" . }}
Expand Down