Added ssl-ports validation in case unused ports are introduced in the aws-load-balancer-ssl-ports annotation #3067

ahrakos · 2023-02-18T16:26:58Z

Issue

Issue Link

fixes #2931

Description

Added tests infrastructure for the buildListenerConfig function
Tested two cases -
- A case where all ports provided in the aws-load-balancer-ssl-ports annotation exists in the spec.Ports section
- A case where part of the ports provided in the aws-load-balancer-ssl-ports annotation do not exist in spec.Ports section
Added a validation function, which takes the array of ports provided in the annotation, and array of ports which is provided in the service's spec, and returns the list of unused ports, and an error if there are unused ports.
Called the validation function from the buildTLSPortsSet function, and threw the error back in the hierarchy

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
[] Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

[] Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

linux-foundation-easycla · 2023-02-18T16:27:02Z

The committers listed above are authorized under a signed CLA.

✅ login: ahrakos (da86d8363e38143cb32e346a1e2cfbc1c7d1cdea)

k8s-ci-robot · 2023-02-18T16:27:07Z

Welcome @ahrakos!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-02-18T16:27:07Z

Hi @ahrakos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahrakos · 2023-02-18T19:09:58Z

/assign

k8s-ci-robot · 2023-02-21T17:42:56Z

@ahrakos: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov-commenter · 2023-02-22T17:24:37Z

Codecov Report

Base: 54.32% // Head: 54.40% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (da86d83) compared to base (e1fb94a).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
+ Coverage   54.32%   54.40%   +0.07%     
==========================================
  Files         145      145              
  Lines        8410     8429      +19     
==========================================
+ Hits         4569     4586      +17     
- Misses       3511     3512       +1     
- Partials      330      331       +1

Impacted Files	Coverage Δ
pkg/service/model_build_listener.go	`90.90% <91.66%> (-0.30%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

johngmyers · 2023-02-22T22:51:02Z

/ok-to-test

kishorj · 2023-02-23T01:33:45Z

You also need to modify the e2e tests since we now validate the ssl-ports.

ahrakos · 2023-02-25T20:34:35Z

@kishorj
Can you finally approve?
I managed to fix the e2e tests :)

kishorj

I have some nit comments, changes look good otherwise.

kishorj · 2023-02-28T00:59:40Z

pkg/service/model_build_listener.go

@@ -115,10 +119,43 @@ func (t *defaultModelBuildTask) buildListenerCertificates(_ context.Context) []e
 	return certificates
 }

-func (t *defaultModelBuildTask) buildTLSPortsSet(_ context.Context) sets.String {
+func validateTLSPortsSet(rawTLSPorts []string, ports []corev1.ServicePort) ([]string, error) {


since the return value is not used, lets just return error from this function

kishorj · 2023-03-10T23:11:00Z

/lgtm
/approve

k8s-ci-robot · 2023-03-10T23:11:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrakos, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ssl-ports annotation

ahrakos · 2023-03-11T10:49:24Z

/lgtm

k8s-ci-robot · 2023-03-11T10:49:25Z

@ahrakos: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kishorj · 2023-03-20T15:39:00Z

/lgtm

…ssl-ports annotation (kubernetes-sigs#3067)

Merge in DEL/aws-load-balancer-controller-fork from update-from-upstream to main * commit '9bbcc80fd4e701018636af4147b27d69e4f128d3': update ko to v0.13.0 (kubernetes-sigs#3115) update module dependencies (kubernetes-sigs#3114) added validation for dummy ports introduced in the aws-load-balancer-ssl-ports annotation (kubernetes-sigs#3067) docs: add a new page about security groups management (kubernetes-sigs#2988) Add InboundCIDRs field to IngressClassParams (kubernetes-sigs#3089) Add SSLPolicy field to IngressClassParams (kubernetes-sigs#3025) enable EndpointsFailOpen by default (kubernetes-sigs#3078)

…ssl-ports annotation (kubernetes-sigs#3067)

k8s-ci-robot requested review from johngmyers and kishorj February 18, 2023 16:27

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 18, 2023

k8s-ci-robot assigned ahrakos Feb 18, 2023

ahrakos removed their assignment Feb 19, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2023

ahrakos force-pushed the ssl-ports-validation branch 5 times, most recently from 80e05c6 to ed0ca12 Compare February 25, 2023 19:07

kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 28, 2023

kishorj reviewed Feb 28, 2023

View reviewed changes

ahrakos force-pushed the ssl-ports-validation branch from ed0ca12 to a739661 Compare February 28, 2023 20:37

ahrakos requested review from kishorj and removed request for johngmyers February 28, 2023 20:38

kishorj approved these changes Mar 10, 2023

View reviewed changes

k8s-ci-robot assigned kishorj Mar 10, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023

kishorj removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2023

added validation for dummy ports introduced in the aws-load-balancer-…

b275e44

…ssl-ports annotation

ahrakos force-pushed the ssl-ports-validation branch from a739661 to b275e44 Compare March 11, 2023 08:54

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2023

k8s-ci-robot merged commit a6c9352 into kubernetes-sigs:main Mar 20, 2023

This was referenced Apr 14, 2023

🥳 aws-load-balancer-controller v2.5.0 Automated Release! 🥑 aws/eks-charts#932

Closed

🥳 aws-load-balancer-controller v2.5.0 Automated Release! 🥑 aws/eks-charts#933

Merged

johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Aug 21, 2023

added validation for dummy ports introduced in the aws-load-balancer-…

88355bb

…ssl-ports annotation (kubernetes-sigs#3067)

oliviassss mentioned this pull request Oct 4, 2023

'service.beta.kubernetes.io/aws-load-balancer-ssl-ports' annotation doesn't seems to work as expected #3414

Closed

Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023

added validation for dummy ports introduced in the aws-load-balancer-…

6f3d182

…ssl-ports annotation (kubernetes-sigs#3067)

Added ssl-ports validation in case unused ports are introduced in the aws-load-balancer-ssl-ports annotation #3067

Added ssl-ports validation in case unused ports are introduced in the aws-load-balancer-ssl-ports annotation #3067

Uh oh!

Conversation

ahrakos commented Feb 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Uh oh!

linux-foundation-easycla bot commented Feb 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 18, 2023

Uh oh!

k8s-ci-robot commented Feb 18, 2023

Uh oh!

ahrakos commented Feb 18, 2023

Uh oh!

k8s-ci-robot commented Feb 21, 2023

Uh oh!

codecov-commenter commented Feb 22, 2023

Codecov Report

Uh oh!

johngmyers commented Feb 22, 2023

Uh oh!

kishorj commented Feb 23, 2023

Uh oh!

ahrakos commented Feb 25, 2023

Uh oh!

kishorj left a comment

Choose a reason for hiding this comment

Uh oh!

kishorj Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

ahrakos Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

kishorj commented Mar 10, 2023

Uh oh!

k8s-ci-robot commented Mar 10, 2023

Uh oh!

ahrakos commented Mar 11, 2023

Uh oh!

k8s-ci-robot commented Mar 11, 2023

Uh oh!

kishorj commented Mar 20, 2023

Uh oh!

Uh oh!

ahrakos commented Feb 18, 2023 •

edited

Loading

linux-foundation-easycla bot commented Feb 18, 2023 •

edited

Loading