Add InboundCIDRs field to IngressClassParams #3089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
==========================================
+ Coverage 54.40% 54.64% +0.23%
==========================================
Files 145 145
Lines 8429 8458 +29
==========================================
+ Hits 4586 4622 +36
+ Misses 3512 3502 -10
- Partials 331 334 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
johngmyers
force-pushed
the
inbound-cidrs
branch
from
2e0eb0c to
956237b
Compare
kishorj
added
the
tide/merge-method-squash
kishorj
approved these changes
Mar 11, 2023
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Apr 14, 2023
johngmyers
added a commit
to johngmyers/aws-load-balancer-controller
that referenced
this pull request
Aug 21, 2023
johngmyers
added a commit
to johngmyers/aws-load-balancer-controller
that referenced
this pull request
Aug 21, 2023
Merge in DEL/aws-load-balancer-controller-fork from update-from-upstream to main * commit '9bbcc80fd4e701018636af4147b27d69e4f128d3': update ko to v0.13.0 (kubernetes-sigs#3115) update module dependencies (kubernetes-sigs#3114) added validation for dummy ports introduced in the aws-load-balancer-ssl-ports annotation (kubernetes-sigs#3067) docs: add a new page about security groups management (kubernetes-sigs#2988) Add InboundCIDRs field to IngressClassParams (kubernetes-sigs#3089) Add SSLPolicy field to IngressClassParams (kubernetes-sigs#3025) enable EndpointsFailOpen by default (kubernetes-sigs#3078)
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2920
Description
Adds an
inboundCIDRsfield to IngressClassParams, to allow overriding thealb.ingress.kubernetes.io/inbound-cidrsannotation for all Ingresses in an IngressClass.Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯