Skip to content

inject client and decoder for webhook #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

inject client and decoder for webhook #135

merged 1 commit into from
Sep 7, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Sep 6, 2018 •
edited
Loading

inject client and decoder for webhook server and underlying webhook handlers

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2018
@mengqiy mengqiy mentioned this pull request Sep 7, 2018
Merged
@droot droot changed the base branch from admissionwebhook to admissionwebhook-1.11 September 7, 2018 21:30
@k8s-ci-robot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 7, 2018
@mengqiy mengqiy closed this Sep 7, 2018
@mengqiy mengqiy reopened this Sep 7, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Sep 7, 2018

It's strange that Tide (Prow) is missing in the presubmit :/

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 976af7e into kubernetes-sigs:admissionwebhook-1.11 Sep 7, 2018
@mengqiy mengqiy deleted the prep_scaffolding branch September 7, 2018 22:07
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@droot
Merge pull request #135 from pwittrock/docs-gen
115464c 
Make docs gen ordering deterministic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @k8s-ci-robot @droot