Skip to content

Rebase admissionwebhook branch on top of master #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 7, 2018
Merged

Rebase admissionwebhook branch on top of master #128

merged 8 commits into from
Sep 7, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Aug 30, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot requested review from deads2k and dims August 30, 2018 22:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 30, 2018
@mengqiy mengqiy requested review from droot and removed request for dims and deads2k August 30, 2018 22:30
@mengqiy mengqiy changed the title Merge admissionwebhook branch to master branch [WIP] Merge admissionwebhook branch to master branch Aug 30, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2018
@mengqiy mengqiy changed the base branch from master to admissionwebhook-1.11 September 7, 2018 01:33
@mengqiy mengqiy changed the title [WIP] Merge admissionwebhook branch to master branch Rebase admissionwebhook branch on top of master Sep 7, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Sep 7, 2018

@droot PTAL

@mengqiy
Copy link
Member Author

mengqiy commented Sep 7, 2018

After this PR merged I will re-target #135 against admissionwebhook-1.11 branch

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ee3ea2 into kubernetes-sigs:admissionwebhook-1.11 Sep 7, 2018
@mengqiy mengqiy deleted the admissionwebhook branch September 7, 2018 21:34
@mengqiy mengqiy mentioned this pull request Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

Assignees

@droot droot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @k8s-ci-robot @droot