Refactor packages to a more flattened structure #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pwittrock
commented
Jun 11, 2018
pwittrock
commented
- move controller subpackages up a level
- decouple ControllerManager from Controller - put them in separate packages
- move cache related types from informers and client into a cache package
… to the new function.
k8s-ci-robot
added
cncf-cla: yes
droot
reviewed
Jun 11, 2018
| ) | ||
|
|
||
| func main() { | ||
| flag.Parse() | ||
| logf.SetLogger(logf.ZapLogger(false)) | ||
|
|
||
| // Setup a Manager | ||
| manager, err := controller.NewManager(controller.ManagerArgs{}) | ||
| mrg, err := manager.New(config.GetConfigOrDie(), manager.Options{}) |
| &source.KindSource{Type: &corev1.Pod{}}, | ||
| &eventhandler.EnqueueHandler{}, | ||
| &source.Kind{Type: &corev1.Pod{}}, | ||
| &handler.Enqueue{}, | ||
| ) |
There was a problem hiding this comment.
+1 New names are much better.
| log.Fatal(err) | ||
| } | ||
|
|
||
| log.Fatal(manager.Start(signals.SetupSignalHandler())) | ||
| log.Fatal(mrg.Start(signals.SetupSignalHandler())) | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks good from end-user's perspective.
k8s-ci-robot
added
the
lgtm
pwittrock
added
the
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Refactor packages to a more flattened structure
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Add docs for generating docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.