Adding string methods for the sources. #170
Conversation
k8s-ci-robot
added
size/S
pkg/source/source.go
Outdated
| @@ -132,6 +136,10 @@ type Channel struct { | |||
| destLock sync.Mutex | |||
| } | |||
|
|
|||
| func (c *Channel) String() string { | |||
| return fmt.Sprintf("channel source: %p", c) | |||
There was a problem hiding this comment.
@DirectXMan12 @droot I chose to print the pointer because I didn't know of a better field to make it identifiable and thoughts?
There was a problem hiding this comment.
hmm..can't think of better alternative in this case.
pkg/source/source.go
Outdated
| @@ -132,6 +136,10 @@ type Channel struct { | |||
| destLock sync.Mutex | |||
| } | |||
|
|
|||
| func (c *Channel) String() string { | |||
| return fmt.Sprintf("channel source: %p", c) | |||
There was a problem hiding this comment.
hmm..can't think of better alternative in this case.
shawn-hurley
force-pushed
the
bugs/issue-153
branch
from
929b286 to
ec674d6
Compare
shawn-hurley
force-pushed
the
bugs/issue-153
branch
from
2b3238d to
dcf51f8
Compare
droot
added
the
lgtm
|
@droot I think if this is good to merge it needs an approved label. Are we waiting on @DirectXMan12 to take a look too? |
droot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: shawn-hurley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding string methods for the sources.
Add skipmap flag to skip validation for AdditionlPropperties
This will set the
Stringmethod for the sources to fix #153