Fix un-initialized once that causes panic #73
Merged
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
LGTM |
mengqiy
reviewed
Jul 9, 2018
pkg/admission/controller_test.go
Outdated
| ) | ||
|
|
||
| func TestCertProvisionerInit(t *testing.T) { | ||
| p := &CertProvisioner{} |
There was a problem hiding this comment.
You need to use a fake client like Client: fake.NewFakeClient().
Otherwise, it will try find the kubeconfig which doesn't exist in the test env.
mengqiy
added
approved
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Fix un-initialized once that causes panic
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Fix container-builder-local repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.