Skip to content

feat: electra sync with testnets #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 145 commits into from
Apr 28, 2025
Merged

feat: electra sync with testnets #1445

merged 145 commits into from
Apr 28, 2025

Conversation

LeanSerra
Copy link
Contributor

@LeanSerra LeanSerra commented Apr 24, 2025 •
edited
Loading

Motivation

We want to sync with Sepolia to test our Electra implementation

Description

  • Fix an error with the enr calculation that prevented us from connecting to peers by updating get_fork_version_for_epoch
  • Add config for the hoodi testnet + a Makefile target to run it. Sourced from here
  • Update the Sepolia config files to use the ones from electra. Sourced from here
  • Update the Holesky config files to use the ones from electra. Sourced from here
  • Update the Mainnet config files to use the ones from electra. Sourced from here

Closes #1439

rodrigo-o and others added 30 commits March 17, 2025 18:33
@rodrigo-o
Setting up electra in version files
e22b626
@rodrigo-o
Avoid skipping electra test in the runners
0dee18e
@rodrigo-o
Updated native libraries to be up-to-date with latest ssz releases
a8b13ec
@rodrigo-o
Updated config/preset to support electra additions
51a5ee4
@rodrigo-o
feat: electra container and ssz support (#1400)
aaa5500
@rodrigo-o
Merge branch 'main' into electra-support
f84cade
@LeanSerra
feat EpochProcessing.process_slashings electra changes
ed74379
@LeanSerra
feat compute_proposer_index changes
71b3674
@LeanSerra
feat compute_sync_committees Electra changes
9aa4202
@LeanSerra
fix fork_choice.ex tests were flaky because env var cleanup was not done
f09b71b 
in fails
@LeanSerra
feat eligible_for_activation_queue Electra changes
df45ee4
@LeanSerra
feat new compounding_withdrawal_credential? Electra function
8fb4d63
@LeanSerra
feat new has_compounding_withdrawal_credential Electra function
6e34108
@LeanSerra
feat new has_execution_withdrawal_credential Electra function
620e700
@LeanSerra
feat fully_withdrawable_validator? Electra changes
d904593
@LeanSerra
feat new get_max_effective_balance Electra function
5445583
@LeanSerra
feat partially_withdrawable_validator? Electra changes
5cbc5af
@LeanSerra
fix typo in struct field in has_compounding_withdrawal_credential
753badb
@LeanSerra
feat new get_committee_indices Electra function
29bf08a
@LeanSerra
feat get_attesting_indices Electra changes
17bf479
@LeanSerra
lint remove unnecessary parentheses in if
42b0bfb
@LeanSerra
feat slash_validator Electra changes
6df1b36
@LeanSerra
feat new get_balance_churn_limit Electra function
9e13ad5
@LeanSerra
feat new get_activation_exit_churn_limit Electra function
abc2585
@LeanSerra
feat compute_exit_epoch_and_churn Electra function
5b7e5dc
@LeanSerra
feat initiate_validator_exit Electra changes
4eddb4b
@LeanSerra
feat process_registry_updates Electra changes
44a00ec
@LeanSerra
refactor remove unused eject_validator(_,_,_, false) variant
9bc3a0b
@LeanSerra @rodrigo-o
feat: electra slashing, proposer_index & compute_sync_committees chan…
e611684 
…ges (#1417)

Co-authored-by: Rodrigo Oliveri <[email protected]>
@LeanSerra
fix compute_exit_epoch_and_update_churn wrong exit_balance calculation
ed8be8a
@LeanSerra LeanSerra self-assigned this Apr 24, 2025
Base automatically changed from electra_max_blobs to electra-support April 25, 2025 20:19
@LeanSerra LeanSerra changed the base branch from electra-support to main April 28, 2025 14:32
@LeanSerra LeanSerra marked this pull request as ready for review April 28, 2025 14:38
@LeanSerra LeanSerra requested a review from a team as a code owner April 28, 2025 14:38
rodrigo-o
rodrigo-o reviewed Apr 28, 2025
View reviewed changes
config/networks/mainnet/config.yaml
Comment on lines -109 to +111
GOSSIP_MAX_SIZE: 10485760
MAX_PAYLOAD_SIZE: 10485760
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit concerned about GOSSIP_MAX_SIZE being removed but here is the PR in the spec: ethereum/consensus-specs#4045

rodrigo-o
rodrigo-o approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@rodrigo-o rodrigo-o merged commit 4c9aa63 into main Apr 28, 2025
15 checks passed
@rodrigo-o rodrigo-o deleted the electra_sync branch April 28, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigo-o rodrigo-o rodrigo-o approved these changes

Assignees

@LeanSerra LeanSerra

Labels
electra
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No peers for optimistic sync in electra
2 participants
@LeanSerra @rodrigo-o