Improve custom pagination view documentation #4824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's simpler to just change the view names. We really shouldn't put views in that vendor folder. I'll fix it. |
taylorotwell
pushed a commit
that referenced
this pull request
Nov 30, 2021
If the callback given to `skipWhile` never returns `false`, then an
empty collection would be returned. Currently the documentation states
the opposite. If the callback never returns `true`, then the whole
collection is returned unfiltered.
```
>>> $collection = collect([1, 2, 3, 4]);
=> Illuminate\Support\Collection {#4833
all: [
1,
2,
3,
4,
],
}
>>> $subset = $collection->skipWhile(function ($item) { return false; });
=> Illuminate\Support\Collection {#4835
all: [
1,
2,
3,
4,
],
}
>>> $subset = $collection->skipWhile(function ($item) { return true; });
=> Illuminate\Support\Collection {#4824
all: [],
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I didn't understood that the
viewpart of the parameter is the name of the file insideresources/views/vendor/pagination.