Skip to content

Windows PATH #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Dec 15, 2018
Merged

Windows PATH #4835

merged 1 commit into from Dec 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2018

No description provided.

@taylorotwell taylorotwell merged commit e33d490 into laravel:master Dec 15, 2018
taylorotwell pushed a commit that referenced this pull request Nov 30, 2021
@bayprogrammer
[8.x] Fix skipWhile callback note (#7474)
b9fe075 
If the callback given to `skipWhile` never returns `false`, then an
empty collection would be returned. Currently the documentation states
the opposite. If the callback never returns `true`, then the whole
collection is returned unfiltered.

```
>>> $collection = collect([1, 2, 3, 4]);
=> Illuminate\Support\Collection {#4833
     all: [
       1,
       2,
       3,
       4,
     ],
   }
>>> $subset = $collection->skipWhile(function ($item) { return false; });
=> Illuminate\Support\Collection {#4835
     all: [
       1,
       2,
       3,
       4,
     ],
   }
>>> $subset = $collection->skipWhile(function ($item) { return true; });
=> Illuminate\Support\Collection {#4824
     all: [],
   }
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taylorotwell