fix: do not block identify on SSE client shutdown completion #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-238745/identify-hang
branch
from
2151118 to
2d05fa1
Compare
cwaldren-ld
force-pushed
the
cw/sc-238745/identify-hang
branch
from
2d05fa1 to
1b857a7
Compare
cwaldren-ld
force-pushed
the
cw/sc-238745/identify-hang
branch
from
23ca6a9 to
dc087b9
Compare
kinyoklion
approved these changes
Apr 3, 2024
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Apr 3, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.4.2</summary> ## [3.4.2](launchdarkly-cpp-client-v3.4.1...launchdarkly-cpp-client-v3.4.2) (2024-04-03) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.3.0 to 0.3.1 </details> <details><summary>launchdarkly-cpp-server: 3.3.4</summary> ## [3.3.4](launchdarkly-cpp-server-v3.3.3...launchdarkly-cpp-server-v3.3.4) (2024-04-03) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.3.0 to 0.3.1 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.4</summary> ## [2.1.4](launchdarkly-cpp-server-redis-source-v2.1.3...launchdarkly-cpp-server-redis-source-v2.1.4) (2024-04-03) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.3.3 to 3.3.4 </details> <details><summary>launchdarkly-cpp-sse-client: 0.3.1</summary> ## [0.3.1](launchdarkly-cpp-sse-client-v0.3.0...launchdarkly-cpp-sse-client-v0.3.1) (2024-04-03) ### Bug Fixes * do not block identify on SSE client shutdown completion ([#384](#384)) ([ca270cd](ca270cd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the
async_shutdownmethod in Foxy client hangs indefinitely. It's not clear to me whether this is because the FD servers are misbehaving, or the client is somehow misbehaving.In any case, this is causing Identify to hang because it waits for
async_shutdowncompletion handler to be invoked before creating a new EventSource client.One solution would be to not wait for that, and just make the new client immediately. That works, but it still leaves the old client sitting in memory waiting forever.
Instead, I've changed the shutdown logic to simply close the TCP socket.