Make funding_transaction_generated take a ChannelId by value
#3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2024-07-chan-by-val
branch
2 times, most recently
from
a2ea38d to
110a1e9
Compare
|
CI is sad. LGTM otherwise. |
TheBlueMatt
force-pushed
the
2024-07-chan-by-val
branch
from
110a1e9 to
003b8ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3214 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 122 122
Lines 101791 101791
Branches 101791 101791
=======================================
+ Hits 91360 91366 +6
+ Misses 7748 7745 -3
+ Partials 2683 2680 -3 ☔ View full report in Codecov by Sentry. |
|
Fuzz is failing |
|
Outside of the call convention change looks like that we need also #3216 to make the build happy See |
TheBlueMatt
force-pushed
the
2024-07-chan-by-val
branch
from
003b8ee to
88b4d42
Compare
`ChannelId` is just a 32-byte array, so there's not a lot of value in passing it by reference to `funding_transaction_generated`, which we fix here. This is also nice for bindings as languages like Java can better analyze whether the `ChannelManager` ends up with a reference to the `ChannelId`.
TheBlueMatt
force-pushed
the
2024-07-chan-by-val
branch
from
88b4d42 to
1ff2495
Compare
valentinewallace
approved these changes
Aug 5, 2024
|
The fuzz test failures are just a (very extended) CI outage. Landing as the change is trivial, even if the patch isn't tiny. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChannelIdis just a 32-byte array, so there's not a lot of value in passing it by reference tofunding_transaction_generated, which we fix here.This is also nice for bindings as languages like Java can better analyze whether the
ChannelManagerends up with a reference to theChannelId.