Pin tokio in CI to fix MSRV
#3216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunxen
approved these changes
Aug 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
==========================================
- Coverage 89.75% 89.73% -0.03%
==========================================
Files 122 122
Lines 101791 101791
Branches 101791 101791
==========================================
- Hits 91367 91342 -25
- Misses 7743 7765 +22
- Partials 2681 2684 +3 ☔ View full report in Codecov by Sentry. |
vincenzopalazzo
approved these changes
Aug 1, 2024
The recently released `tokio` 1.39 bumped their MSRV to rustc 1.70. Here, we pin the `tokio` version to 1.38 for users that require to maintain our MSRV of rustc 1.63.
tnull
force-pushed
the
2024-08-pin-tokio-in-ci
branch
from
7f0fb7d to
3566b98
Compare
|
Kicked CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently released
tokio1.39 bumped their MSRV to rustc 1.70. Here, we pin thetokioversion to 1.38 for users that require to maintain our MSRV of rustc 1.63.