Fix incorrect logging during RBF or rebroadcast #3482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3482 +/- ##
==========================================
- Coverage 89.69% 89.69% -0.01%
==========================================
Files 130 130
Lines 107472 107614 +142
Branches 107472 107614 +142
==========================================
+ Hits 96396 96520 +124
- Misses 8674 8691 +17
- Partials 2402 2403 +1 ☔ View full report in Codecov by Sentry. |
arik-so
reviewed
Dec 11, 2024
lightning/src/chain/onchaintx.rs
Outdated
| @@ -504,7 +504,7 @@ impl<ChannelSigner: EcdsaChannelSigner> OnchainTxHandler<ChannelSigner> { | |||
| .map(|(_, new_feerate, claim)| { | |||
| let mut bumped_feerate = false; | |||
There was a problem hiding this comment.
thanks so much! Can we use this opportunity to also rename bumped_feerate to something like is_feerate_bumped or did_bump_feerate or feerate_was_bumped or really anything that doesn't make it sound as though it's the actual numeric value of the new fee rate?
vincenzopalazzo
approved these changes
Dec 12, 2024
morehouse
force-pushed
the
fix_rebroadcast_logging
branch
from
a7f6a80 to
2620477
Compare
We were incorrectly logging RBF'd transactions as not RBF'd and vice versa.
morehouse
force-pushed
the
fix_rebroadcast_logging
branch
from
2620477 to
94ad5be
Compare
arik-so
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly logging RBF'd transactions as not RBF'd and vice versa.