Fix initial outbound sync infinite loop #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
added
good first issue
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
+ Coverage 90.23% 90.31% +0.07%
==========================================
Files 34 34
Lines 19182 19182
==========================================
+ Hits 17309 17324 +15
+ Misses 1873 1858 -15
Continue to review full report at Codecov.
|
|
Are you thinking tests that could've discovered the CPU usage somehow, or just ones that hit this LoC/function in general? |
|
I assume it should be possible to write a test which would have identified the fact that we'd never have finished syncing the full routing table (as long as there are more than a handful of entries). |
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 20, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 20, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 23, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 23, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 23, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 26, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 26, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 26, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 27, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 27, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 27, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 27, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 27, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
added a commit
to valentinewallace/rust-lightning
that referenced
this pull request
Mar 27, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
|
Merged via 556. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed in testing as 100% CPU usage just sending the routing table over the wire. This would be a great opportunity to add some much-needed testing for this area of the code, so tagging as such - writing such tests is totally up for grabs, anyone is welcome to do so.