Add PeerManager::disconnect_node_id() #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Jan 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #783 +/- ##
========================================
Coverage 91.23% 91.23%
========================================
Files 37 37
Lines 22623 22921 +298
========================================
+ Hits 20639 20911 +272
- Misses 1984 2010 +26
Continue to review full report at Codecov.
|
ariard
force-pushed
the
2021-01-disconnect-node-id
branch
from
c6c6aef to
070ec49
Compare
|
Updated at 070ec49 |
TheBlueMatt
approved these changes
Feb 1, 2021
lightning/src/ln/peer_handler.rs
Outdated
| /// Set no_connection_possible to true to prevent any further connection with this peer, | ||
| /// force-closing any channels we have with it. | ||
| /// | ||
| /// Beware with reentrancy issues about disconnect_socket! |
There was a problem hiding this comment.
Can we state that "if a peer is connected, this will call disconnect_socket on the descriptor for the peer, so be careful about reentrancy issues" - there's no reason to not provide more detail on exactly what will happen.
This public method allows a client to easily disconnect peers while only owning its node id. It will clean up peer state and disconnect properly its descriptor.
ariard
force-pushed
the
2021-01-disconnect-node-id
branch
from
070ec49 to
5b7d7ed
Compare
TheBlueMatt
approved these changes
Feb 1, 2021
|
This is trivial. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This public method allows a client to easily disconnect peers while only
owning its node id. It will clean up peer state and disconnect properly
its descriptor.
Motivation: http://gnusha.org/rust-bitcoin/2021-01-28.log
Required to implement
disconnectcmd on the sample-side, we might rework our PeerManager API andlightning-net-tokioonce we agree on a good interface.