[Update] Account View GET /account - add service_type to active_promotions #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsaihn
approved these changes
Mar 22, 2021
yoshizzle
reviewed
Mar 22, 2021
| service_type: | ||
| type: string | ||
| enum: | ||
| - all |
There was a problem hiding this comment.
All does not show up in the list here: https://bits.linode.com/LinodeAPI/nimbus/blob/development/nimbus/objects/service.py#L26
is that intentional?
There was a problem hiding this comment.
Here's the reference that I picked it up from:
https://bits.linode.com/LinodeAPI/nimbus/blob/development/nimbus/objects/promotion.py#L19
https://bits.linode.com/LinodeAPI/nimbus/pull/1187
My understanding is that a service_type of all in this case is necessary for general promotion credits.
yoshizzle
approved these changes
Mar 22, 2021
|
Cool. I was looking at the wrong enum. :) Lgtm! |
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
…1-06-21 [Header Update] Products Feature: Terraform Provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.