Skip to content

[Update] Account View GET /account - add service_type to active_promotions #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021
Merged

[Update] Account View GET /account - add service_type to active_promotions #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15388,6 +15388,25 @@ components:
description: >
The amount of credit left for this month for this promotion.
example: "10.00"
service_type:
type: string
enum:
- all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All does not show up in the list here: https://bits.linode.com/LinodeAPI/nimbus/blob/development/nimbus/objects/service.py#L26

is that intentional?

cc @nbokoski @bbiggerr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the reference that I picked it up from:
https://bits.linode.com/LinodeAPI/nimbus/blob/development/nimbus/objects/promotion.py#L19
https://bits.linode.com/LinodeAPI/nimbus/pull/1187

My understanding is that a service_type of all in this case is necessary for general promotion credits.

- backup
- blockstorage
- db_mysql
- ip_v4
- linode
- linode_disk
- linode_memory
- longview
- managed
- nodebalancer
- objectstorage
- transfer_tx
description: >
The service to which this promotion applies.
example: "all"
active_since:
type: string
format: date-time
Expand Down