brk: param changes to POST /networking/ips and /linode/instances/:id/ips #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jamesottinger
commented
Mar 28, 2018
jamesottinger
commented
- POST /networking/ips - now accepts "type":"ipv4" and "public":bool
- POST /networking/ips - can do private ipv4 addresses
- POST /linode/instances/:id/ips - now accepts "type":"ipv4" and "public":bool
jamesottinger
force-pushed
the
networkingtype
branch
from
848f802 to
d234601
Compare
jamesottinger
changed the title
Dorthu
requested changes
Mar 28, 2018
src/data/endpoints/linodes.yaml
Outdated
| @@ -869,23 +869,27 @@ endpoints: | |||
| money: true | |||
| oauth: linodes:modify | |||
| description: > | |||
| Allocates a new IP Address for this Linode. | |||
| Allocates a new IPv4 IP Address for this Linode. | |||
There was a problem hiding this comment.
IPv4 Address (remove "IP")
| subtype: IPAddressType | ||
| value: public | ||
| description: The type of IP Address, either public or private. | ||
| type: String |
There was a problem hiding this comment.
This could probably still be an Enum of ipv4, ipv6, ipv6/range, and ipv6/pool, but I don't feel that strongly about it.
| description: The type of IP Address, either public or private. | ||
| type: String | ||
| description: The type of IP Address. | ||
| value: ipv4 | ||
| enums: |
There was a problem hiding this comment.
This enum is now irrelevant - I'd change is as described above, but it could also be removed
jamesottinger
force-pushed
the
networkingtype
branch
from
d234601 to
78d8d78
Compare
Dorthu
approved these changes
Mar 28, 2018
yoshizzle
requested changes
Mar 28, 2018
src/data/endpoints/linodes.yaml
Outdated
| public: | ||
| type: Boolean | ||
| description: > | ||
| Whether this is a public of private IP address. |
src/data/endpoints/networking.yaml
Outdated
| public: | ||
| type: Boolean | ||
| description: > | ||
| Whether this is a public of private IP address. |
src/data/objects/ipaddress.yaml
Outdated
| public: | ||
| type: Boolean | ||
| value: true | ||
| description: Whether this is a public of private IP address. |
| region: | ||
| type: String | ||
| value: us-east | ||
| description: The region this IP is in. |
| public: | ||
| type: Boolean | ||
| value: false | ||
| description: Whether this is a public of private IP address. |
| public: | ||
| type: Boolean | ||
| value: true | ||
| description: Whether this is a public of private IP address. |
- POST /networking/ips - now accepts "type":"ipv4" and "public":bool - POST /networking/ips - can do private ipv4 addresses - POST /linode/instances/:id/ips - now accepts "type":"ipv4" and "public":bool
jamesottinger
force-pushed
the
networkingtype
branch
from
78d8d78 to
086bc19
Compare
yoshizzle
approved these changes
Mar 28, 2018
alioso
pushed a commit
that referenced
this pull request
Aug 22, 2019
Made all document links absolute
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Updating image to new dimensions
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
…0-72-0 Create Changelogs “cloud-manager-changelog-0-72-0”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.