-
Notifications
You must be signed in to change notification settings - Fork 69
brk: param changes to POST /networking/ips and /linode/instances/:id/ips #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
name: IP Address | ||
description: > | ||
An IP Address | ||
An IPv4 Address | ||
schema: | ||
address: | ||
type: String | ||
|
@@ -26,16 +26,19 @@ schema: | |
region: | ||
type: String | ||
value: us-east | ||
description: The region this IP is in. | ||
description: The Region this IP is in. | ||
subnet_mask: | ||
type: String | ||
value: 255.255.255.0 | ||
description: The subnet mask. | ||
public: | ||
type: Boolean | ||
value: true | ||
description: Whether this is a public or private IP address. | ||
type: | ||
type: Enum | ||
subtype: IPAddressType | ||
value: public | ||
description: The type of IP Address, either public or private. | ||
type: String | ||
description: The type of IP Address. | ||
value: ipv4 | ||
enums: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This enum is now irrelevant - I'd change is as described above, but it could also be removed |
||
IPAddressType: | ||
public: Public IP Address. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
name: IP Address | ||
description: > | ||
An IPv6 Address - link_local | ||
schema: | ||
address: | ||
type: String | ||
value: fe80::f03c:91ff:fe24:3a2f | ||
description: The IP Address. | ||
gateway: | ||
type: String | ||
value: fe80::1 | ||
description: The default gateway. | ||
linode_id: | ||
type: Integer | ||
value: 42 | ||
description: The Linode this IP is associated with. | ||
prefix: | ||
type: String | ||
value: 64 | ||
description: The network prefix. | ||
rdns: | ||
editable: true | ||
type: String | ||
value: null | ||
description: Reverse DNS address for this IP Address. Null to reset. | ||
region: | ||
type: String | ||
value: us-east | ||
description: The Region this IP is in. | ||
subnet_mask: | ||
type: String | ||
value: ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | ||
description: The subnet mask. | ||
public: | ||
type: Boolean | ||
value: false | ||
description: Whether this is a public or private IP address. | ||
type: | ||
type: String | ||
description: The type of IP Address. | ||
value: ipv6 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
name: IP Address | ||
description: > | ||
An IPv6 Address - slaac | ||
schema: | ||
address: | ||
type: String | ||
value: 2600:3c03::f03c:91ff:fe24:3a2f | ||
description: The IP Address. | ||
gateway: | ||
type: String | ||
value: fe80::1 | ||
description: The default gateway. | ||
linode_id: | ||
type: Integer | ||
value: 42 | ||
description: The Linode this IP is associated with. | ||
prefix: | ||
type: String | ||
value: 64 | ||
description: The network prefix. | ||
rdns: | ||
editable: true | ||
type: String | ||
value: "example.org" | ||
description: Reverse DNS address for this IP Address. Null to reset. | ||
region: | ||
type: String | ||
value: us-east | ||
description: The Region this IP is in. | ||
subnet_mask: | ||
type: String | ||
value: ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | ||
description: The subnet mask. | ||
public: | ||
type: Boolean | ||
value: true | ||
description: Whether this is a public or private IP address. | ||
type: | ||
type: String | ||
description: The type of IP Address. | ||
value: ipv6 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably still be an Enum of
ipv4
,ipv6
,ipv6/range
, andipv6/pool
, but I don't feel that strongly about it.