Skip to content

Add Linux to the Build Matrix #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2017
Merged

Add Linux to the Build Matrix #13

merged 2 commits into from
Jan 15, 2017

Conversation

CodaFi
Copy link
Member

@CodaFi CodaFi commented Jan 9, 2017

No description provided.

@harlanhaskins
Copy link
Member

We should just set

PKG_CONFIG_PATH=$(pwd):$(PKG_CONFIG_PATH)

And call it a day.

@CodaFi CodaFi force-pushed the we-global branch 3 times, most recently from f5441f1 to 62a002c Compare January 13, 2017 07:16
@CodaFi
Copy link
Member Author

CodaFi commented Jan 13, 2017

I'm out of ideas. Can you talk to Ankit about this?

@CodaFi CodaFi mentioned this pull request Jan 14, 2017
Merged
@CodaFi
Copy link
Member Author

CodaFi commented Jan 14, 2017

Looks like Process was still called Task when this snapshot was put out.

@harlanhaskins
Copy link
Member

Try 3.0.2?

@CodaFi
Copy link
Member Author

CodaFi commented Jan 14, 2017

Gonna fold these commits after seeing what happens. The first has 3.0 snapshot and uses Task, the second has 3.0.2 snapshot and uses Process.

@CodaFi
Copy link
Member Author

CodaFi commented Jan 14, 2017

No dice.

@harlanhaskins
Copy link
Member

Well, won't that fail on macOS? What about

#if os(Linux)
typealias Process = Task
#endif

@CodaFi CodaFi force-pushed the we-global branch 13 times, most recently from 2c61804 to 6bcc4aa Compare January 15, 2017 03:45
@CodaFi
Copy link
Member Author

CodaFi commented Jan 15, 2017

@harlanhaskins I'm happy with this. Review please!

@CodaFi CodaFi force-pushed the we-global branch 2 times, most recently from f9e7c17 to 04f9912 Compare January 15, 2017 03:55
@CodaFi CodaFi force-pushed the we-global branch 5 times, most recently from ed28b09 to f168d0b Compare January 15, 2017 04:21
@harlanhaskins harlanhaskins merged commit 24c6f37 into llvm-swift:master Jan 15, 2017
@harlanhaskins
Copy link
Member

Yay!

@CodaFi CodaFi deleted the we-global branch January 15, 2017 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @harlanhaskins