Skip to content

Added utility for generating a pkg-config file #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2017
Merged

Conversation

harlanhaskins
Copy link
Member

No description provided.

Copy link
Member

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@harlanhaskins
Copy link
Member Author

This is untested on Linux, but this should cover the case of "we need to make a pkg-config file for every distro?!"

@CodaFi
Copy link
Member

CodaFi commented Jan 14, 2017

I'll update #13 with it

@harlanhaskins
Copy link
Member Author

Don't merge quite yet. I'm updating the README.

@harlanhaskins
Copy link
Member Author

Merge if you approve the latest README changes

- Install LLVM 3.9 using your favorite package manager. For example:
- `brew install llvm`
- Ensure `llvm-config` is in your `PATH`
- That will reside in the `/bin` folder wherever your package manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is all that helpful, users don't really need to know this location to build. Maybe mention invoking which llvm-config or something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It helped me because it didn't end up in my path after installing from homebrew :sad:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Carry on.

@CodaFi
Copy link
Member

CodaFi commented Jan 14, 2017

:shipit:

⛵️

@CodaFi CodaFi merged commit 3b17e85 into master Jan 14, 2017
@CodaFi CodaFi deleted the pc-on-linux branch January 14, 2017 23:24
@harlanhaskins
Copy link
Member Author

Now let's get #13 working!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants