[SandboxIR][NFC] Fixes for LoadInst::create functions #100955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wizardengineer
changed the title
vporpo
reviewed
Jul 29, 2024
wizardengineer
commented
Jul 29, 2024
vporpo
reviewed
Jul 29, 2024
vporpo
reviewed
Jul 29, 2024
vporpo
approved these changes
Jul 29, 2024
|
Btw isVolatile is also missing from StoreInst, so feel free to update that as well. |
StoreInst: #100961 (btw, I have to add similar changes to the ones you discussed here onto the StoreInst PR. Mainly the test.) @vporpo if it's okay with you, I needed help with understanding why the bot checks were failing for the StoreInst PR I created. if you have time are you able to check it out for me? I was struggling to find a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were discussed here: #100850 (comment)
cc: @vporpo