[llvm] add support for mustache templating language #105893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
ilovepi
reviewed
Aug 26, 2024
…m-project into llvm-add-mustache
…m-project into llvm-add-mustache
ilovepi
reviewed
Sep 7, 2024
There was a problem hiding this comment.
Overall a good start, but I think we can tighten up the implementation in a few places, and improve the documentation here quite a bit.
I'd also like to see a somewhat expanded comment block in the header, describing the overall design of the library. This is a pattern you'll see a lot in LLVM, and its usually appreciated.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 11, 2025
…e" (#130720) Reverts llvm/llvm-project#105893 since it broke all builders that use GCC as the compiler.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/127/builds/2671 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/2470 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/5003 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/97/builds/5441 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/99/builds/5258 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/75/builds/5550 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/118/builds/5204 Here is the relevant piece of the build log for the reference |
PeterChou1
added a commit
that referenced
this pull request
Mar 12, 2025
Reapply #105893 Fixes errors which broke build bot that uses GCC as a compiler https://lab.llvm.org/buildbot/#/builders/136/builds/3100 The issue here was that using Accessor defined in the anonymous namespace introduces Accessor as a type alias. Which is, later redeclare as members in classes Token and ASTNode with the same name which causes error in GCC. The patch fixes it by renaming the Accesor to AccessorValue. It also fixes warnings caused by the compile due to initialization Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html This patch implements support+tests for majority of the features of the language including: - Variables - Comments - Lambdas - Sections This meant as a library to support places where we have to generate HTML, such as in clang-doc.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 12, 2025
…e (#130732) Reapply llvm/llvm-project#105893 Fixes errors which broke build bot that uses GCC as a compiler https://lab.llvm.org/buildbot/#/builders/136/builds/3100 The issue here was that using Accessor defined in the anonymous namespace introduces Accessor as a type alias. Which is, later redeclare as members in classes Token and ASTNode with the same name which causes error in GCC. The patch fixes it by renaming the Accesor to AccessorValue. It also fixes warnings caused by the compile due to initialization Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html This patch implements support+tests for majority of the features of the language including: - Variables - Comments - Lambdas - Sections This meant as a library to support places where we have to generate HTML, such as in clang-doc.
PeterChou1
added a commit
that referenced
this pull request
Mar 12, 2025
#130873) This patch caused certain GCC buildbots to failed errors: https://lab.llvm.org/buildbot/#/builders/66/builds/11049
VishMCW
pushed a commit
to VishMCW/llvm-project
that referenced
this pull request
Mar 18, 2025
…0720) Reverts llvm#105893 since it broke all builders that use GCC as the compiler.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/98/builds/1305 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html
This patch implements support+tests for majority of the features of the language including:
This meant as a library to support places where we have to generate HTML, such as in clang-doc.